His life would change drastically. He would be surrounded by different magic and different values. Instead of the traditional Hogwarts education, he'd get a more spiritual and otherworldly form of teaching. He might not be as naive about the dark side of magic as he was in the original story.
He becomes more humble. Elves are used to serving and being in a subservient position. Growing up with them, Harry would learn the value of every being, no matter their status. He'd be less likely to show off his magical abilities like he might have in the original story.
He'd be more adaptable. Quarians live in a different way than wizards, so Harry would learn to be flexible in new situations.
His personality would likely be more cold and calculating. He'd be used to getting his way through underhanded means taught by the villains.
His character becomes more confident. Since he was raised by a god, he has a certain level of self - assurance that normal Harry might not have. He may not be as easily intimidated by Voldemort or other threats.
His personality might become more alluring like the Veela. He could be more confident in his appearance and charm, which is different from the somewhat self - doubting Harry in the original story. He may also be more in tune with his emotions as Veela are known for their passionate nature.
He would likely be more confident in his physical abilities. Yoruichi is a very capable fighter, and if she raised Harry, he would be trained in combat. So he might not be as hesitant in dangerous situations as the original Harry. He could be more likely to take risks and trust in his own strength.
Harry would probably be more attuned to dark magic. His upbringing by Satan would expose him to different forms of magic and he would have a different understanding of power. He might be more ruthless in achieving his goals and less concerned about the consequences for others. For example, in the original series, Harry was always worried about the safety of his friends, but in this fanfiction, he might use his friends as pawns if it served his purpose.
Harry in this fanfiction is likely to be more ruthless. Voldemort's upbringing would make him less empathetic. He may value power above all else and be more willing to use dark magic to achieve his goals. His relationships would also be different. He wouldn't have the same close - knit group of friends as in the original story. Instead, he might be surrounded by Death Eaters or those who follow Voldemort's ideology.
He would be more cunning. Maleficent is a master of manipulation, and Harry would likely pick up on those skills. He might be less naive compared to the original Harry.
He'd be more reserved. Vergil isn't exactly a talkative and outgoing person. Harry would likely follow suit, keeping his thoughts and feelings to himself more often.